<html>
<head><meta charset="utf-8"><title>meeting 2020-oct-1 · t-lang/project-never-type · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/index.html">t-lang/project-never-type</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html">meeting 2020-oct-1</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="211941273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941273">(Oct 01 2020 at 17:01)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>  <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="211941289"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941289" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941289">(Oct 01 2020 at 17:01)</a>:</h4>
<p>Hi</p>



<a name="211941549"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941549" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941549">(Oct 01 2020 at 17:02)</a>:</h4>
<p>Are you ready for the meeting ?</p>



<a name="211941676"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941676" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941676">(Oct 01 2020 at 17:04)</a>:</h4>
<p>yep</p>



<a name="211941714"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941714" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941714">(Oct 01 2020 at 17:04)</a>:</h4>
<p>sorry</p>



<a name="211941717"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941717" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941717">(Oct 01 2020 at 17:04)</a>:</h4>
<p>so, what's up?</p>



<a name="211941724"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941724" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941724">(Oct 01 2020 at 17:04)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/74535/files#diff-635b28f19e86863f9d886d3b9a7beaa7R207">This</a> is the latest PR, but of course it fails builds</p>



<a name="211941728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941728">(Oct 01 2020 at 17:04)</a>:</h4>
<p><span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="211941767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941767">(Oct 01 2020 at 17:04)</a>:</h4>
<p>yeah ok right</p>



<a name="211941781"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941781" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941781">(Oct 01 2020 at 17:04)</a>:</h4>
<p>so I think that line of code isn't quite where I imagined it should go</p>



<a name="211941796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941796">(Oct 01 2020 at 17:04)</a>:</h4>
<p>Based on the last discussion it looked like that wasn't the right place</p>



<a name="211941868"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941868" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941868">(Oct 01 2020 at 17:05)</a>:</h4>
<p>I think you want <a href="https://github.com/rust-lang/rust/blob/3507d2719a6a70fff65e56e239651da1a085ee05/compiler/rustc_typeck/src/check/expr.rs#L215-L217">more around these 3 lines</a></p>



<a name="211941878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941878">(Oct 01 2020 at 17:05)</a>:</h4>
<p>something like this:</p>



<a name="211941913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211941913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211941913">(Oct 01 2020 at 17:05)</a>:</h4>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="w">        </span><span class="c1">// Combine the diverging and has_error flags.</span>
<span class="w">        </span><span class="bp">self</span><span class="p">.</span><span class="n">diverges</span><span class="p">.</span><span class="n">set</span><span class="p">(</span><span class="bp">self</span><span class="p">.</span><span class="n">diverges</span><span class="p">.</span><span class="n">get</span><span class="p">()</span><span class="w"> </span><span class="o">|</span><span class="w"> </span><span class="n">old_diverges</span><span class="p">);</span><span class="w"></span>
<span class="w">        </span><span class="bp">self</span><span class="p">.</span><span class="n">has_errors</span><span class="p">.</span><span class="n">set</span><span class="p">(</span><span class="bp">self</span><span class="p">.</span><span class="n">has_errors</span><span class="p">.</span><span class="n">get</span><span class="p">()</span><span class="w"> </span><span class="o">|</span><span class="w"> </span><span class="n">old_has_errors</span><span class="p">);</span><span class="w"></span>

<span class="w">        </span><span class="k">if</span><span class="w"> </span><span class="bp">self</span><span class="p">.</span><span class="n">diverges</span><span class="p">.</span><span class="n">get</span><span class="p">().</span><span class="n">diverges</span><span class="p">()</span><span class="w"> </span><span class="p">{</span><span class="w"> </span><span class="bp">self</span><span class="p">.</span><span class="n">dead_nodes</span><span class="p">.</span><span class="n">borrow_mut</span><span class="p">().</span><span class="n">insert</span><span class="p">(</span><span class="n">expr</span><span class="p">.</span><span class="n">hir_id</span><span class="p">);</span><span class="w"> </span><span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="211942036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942036">(Oct 01 2020 at 17:06)</a>:</h4>
<p>I see, I was going to debug what difference is there and why is it set at two locations.</p>



<a name="211942099"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942099" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942099">(Oct 01 2020 at 17:06)</a>:</h4>
<p>so as an example</p>



<a name="211942102"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942102" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942102">(Oct 01 2020 at 17:06)</a>:</h4>
<p>Didn't get a chance last night</p>



<a name="211942104"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942104" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942104">(Oct 01 2020 at 17:06)</a>:</h4>
<p>you might have</p>



<a name="211942136"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942136" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942136">(Oct 01 2020 at 17:07)</a>:</h4>
<p><code>{panic!(); 22}</code></p>



<a name="211942150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942150">(Oct 01 2020 at 17:07)</a>:</h4>
<p>that is an expression whose <em>type</em> is <code>i32</code></p>



<a name="211942154"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942154" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942154">(Oct 01 2020 at 17:07)</a>:</h4>
<p>but it diverges</p>



<a name="211942209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942209">(Oct 01 2020 at 17:07)</a>:</h4>
<p>Ahh ! Makes sense</p>



<a name="211942214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942214">(Oct 01 2020 at 17:07)</a>:</h4>
<p>as opposed to <code>panic!()</code>, which is an expression whose type is <code>!</code> (well, a variable that falls back to <code>!</code>) and diverges</p>



<a name="211942219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942219">(Oct 01 2020 at 17:07)</a>:</h4>
<p>cool</p>



<a name="211942411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942411">(Oct 01 2020 at 17:08)</a>:</h4>
<p>Sounds good. Thanks. I will add comments.</p>



<a name="211942420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942420">(Oct 01 2020 at 17:08)</a>:</h4>
<p>the question I guess is whether this will help</p>



<a name="211942450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942450">(Oct 01 2020 at 17:09)</a>:</h4>
<p>Okay, so next steps <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="211942503"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942503" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942503">(Oct 01 2020 at 17:09)</a>:</h4>
<p>Ahh ! ya. if it does not help then we are back to current step <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="211942655"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942655" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942655">(Oct 01 2020 at 17:10)</a>:</h4>
<p>Okay so I will make the change and run the tests locally to see how much it helps.</p>



<a name="211942749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942749">(Oct 01 2020 at 17:10)</a>:</h4>
<p>yeah that's probably the right next step</p>



<a name="211942764"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942764" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942764">(Oct 01 2020 at 17:11)</a>:</h4>
<p>Let's say it does, then for the linting part we are set ?</p>



<a name="211942769"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942769" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942769">(Oct 01 2020 at 17:11)</a>:</h4>
<p>hopefully it does make <a href="http://weird-exprs.rs">weird-exprs.rs</a> work and everything</p>



<a name="211942788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942788">(Oct 01 2020 at 17:11)</a>:</h4>
<p>then I think we can remove the <code>allow</code> from libcore and see if that works</p>



<a name="211942797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942797">(Oct 01 2020 at 17:11)</a>:</h4>
<p>if so, great</p>



<a name="211942813"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942813" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942813">(Oct 01 2020 at 17:11)</a>:</h4>
<p>if not, we have to isolate what's going on more closely</p>



<a name="211942844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942844">(Oct 01 2020 at 17:11)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/259160-t-lang.2Fproject-never-type/topic/meeting.202020-oct-1/near/211942788">said</a>:</p>
<blockquote>
<p>then I think we can remove the <code>allow</code> from libcore and see if that works</p>
</blockquote>
<p>You mean make it <code>deny by default</code> ?</p>



<a name="211942958"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211942958" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211942958">(Oct 01 2020 at 17:12)</a>:</h4>
<p>well we added in some <code>#![allow(...)]</code> statements into libcore etc, right?</p>



<a name="211943055"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211943055" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211943055">(Oct 01 2020 at 17:13)</a>:</h4>
<p>ohh ! I didn't add those changes to the PR</p>



<a name="211943094"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211943094" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211943094">(Oct 01 2020 at 17:13)</a>:</h4>
<p>ah, ok</p>



<a name="211943098"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211943098" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211943098">(Oct 01 2020 at 17:13)</a>:</h4>
<p>then we don't have to remove them :)</p>



<a name="211943239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211943239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211943239">(Oct 01 2020 at 17:14)</a>:</h4>
<p>Do you have pointers on which way I should look if that does not work ? Given it is weekend soon, I can do more exploration !</p>



<a name="211943856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211943856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211943856">(Oct 01 2020 at 17:18)</a>:</h4>
<p>Okay so we are at time. So, I will summarize here:</p>
<ol>
<li>Stick the add to dead_nodes below the if block (from where it currently is).</li>
<li>If that does not work(weird-exprs tests don't pass), then take a breath of fresh air and comeback and debug <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></li>
</ol>



<a name="211943896"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211943896" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211943896">(Oct 01 2020 at 17:19)</a>:</h4>
<p><span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="211992053"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211992053" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211992053">(Oct 02 2020 at 00:23)</a>:</h4>
<p><span class="user-mention" data-user-id="128294">@blitzerr</span> sorry, got a phone call -- but that sounds right! I don't have any pointers really for how to track down the allow, except to try and create standalone <code>#![no_std]</code> examples</p>



<a name="211992064"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211992064" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211992064">(Oct 02 2020 at 00:23)</a>:</h4>
<p>honestly if you find that you can't build libcore even with the changes</p>



<a name="211992070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211992070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211992070">(Oct 02 2020 at 00:23)</a>:</h4>
<p>just ignore it and add <code>#![allow]</code> again and we can investigate together</p>



<a name="211992088"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/211992088" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#211992088">(Oct 02 2020 at 00:24)</a>:</h4>
<p>well, that is, if there are things to do after that</p>



<a name="212001398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212001398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212001398">(Oct 02 2020 at 03:35)</a>:</h4>
<p>Sounds good <span class="user-mention" data-user-id="116009">@nikomatsakis</span>.</p>



<a name="212417599"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212417599" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212417599">(Oct 06 2020 at 12:09)</a>:</h4>
<p><span class="user-mention" data-user-id="128294">@blitzerr</span> any luck over the weekend?</p>



<a name="212426616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212426616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212426616">(Oct 06 2020 at 13:25)</a>:</h4>
<p>Unfortunately, even after adding the line (which adds to dead_nodes) towards the end of evaluation, libcore still does not compile.</p>



<a name="212426684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212426684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212426684">(Oct 06 2020 at 13:26)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/74535/files#diff-635b28f19e86863f9d886d3b9a7beaa7R217">Changes</a> are here.</p>



<a name="212426839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212426839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212426839">(Oct 06 2020 at 13:27)</a>:</h4>
<p>But all in all, we still have lib-core failing, So couldn't get to the weird-expr test case. <span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<a name="212479299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212479299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212479299">(Oct 06 2020 at 20:13)</a>:</h4>
<p><span class="user-mention" data-user-id="128294">@blitzerr</span> maybe we should schedule some time to dig into this</p>



<a name="212479324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212479324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212479324">(Oct 06 2020 at 20:13)</a>:</h4>
<p>I can share some of the "tricks of the trade"</p>



<a name="212485808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212485808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212485808">(Oct 06 2020 at 21:07)</a>:</h4>
<p>Sure ! I would love that <span aria-label="grinning" class="emoji emoji-1f600" role="img" title="grinning">:grinning:</span> <span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<a name="212601052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212601052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212601052">(Oct 07 2020 at 18:39)</a>:</h4>
<p><span class="user-mention" data-user-id="128294">@blitzerr</span> when generally are you available? feel free to respond in privmsg, actually</p>



<a name="212617863"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212617863" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212617863">(Oct 07 2020 at 20:55)</a>:</h4>
<p>actually <span class="user-mention" data-user-id="128294">@blitzerr</span> how about we use 30 minutes at our sync time tomorrow and connect via zoom?</p>



<a name="212620884"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259160-t-lang/project-never-type/topic/meeting%202020-oct-1/near/212620884" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> blitzerr <a href="https://rust-lang.github.io/zulip_archive/stream/259160-t-lang/project-never-type/topic/meeting.202020-oct-1.html#212620884">(Oct 07 2020 at 21:20)</a>:</h4>
<p>Sounds good. Let's do that <span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>